fix(devtools-connect): fix TLS error fallback mechanism MONGOSH-2488 #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restructure our proxy integration logic to: - Avoid modifying the OIDC options – previously we were assigning to `clientOptions.oidc`, which meant that the `fetch` function created to read the system certificates was also used for the non-system-cert `connect()` call, breaking our fallback mechanism - Add a test that verifies that the fallback mechanism works both for TLS driver connections and HTTPS OIDC calls. - Deduplicate the logic for adding CA options to the `DevtoolsProxyOptions` instances. - Share log info from the OIDC agent instance, if a new one has been created. - Make sure that TLS errors passed through node-fetch are actually picked up by our "nested error" detection logic (they have a different `toStringTag` defined than regular `Error` instances).
addaleax
commented
Aug 13, 2025
| clientOptions.oidc = { | ||
| customFetch: createFetch( | ||
| oidcProxyOptions, | ||
| ) as unknown as MongoDBOIDCPluginOptions['customFetch'], |
There was a problem hiding this comment.
^ I think this statement was the core of the bug here, we were assigning to clientOptions.oidc, so the retry-without-system-certs call would use the same customFetch function as the initial one with system certs
kmruiz
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure our proxy integration logic to:
clientOptions.oidc, which meant that thefetchfunction created to read the system certificates was also used for the non-system-certconnect()call, breaking our fallback mechanismDevtoolsProxyOptionsinstances.toStringTagdefined than regularErrorinstances).Description
Open Questions
Checklist